Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Use GitHub Actions CI #14

Merged
merged 1 commit into from
Jul 17, 2022
Merged

MNT Use GitHub Actions CI #14

merged 1 commit into from
Jul 17, 2022

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jun 29, 2022 •
edited
Loading

@emteknetnz emteknetnz force-pushed the pulls/4.10/module-standards branch 4 times, most recently from 2dd2b9e to a44cde7 Compare July 4, 2022 03:56
@emteknetnz emteknetnz mentioned this pull request Jul 5, 2022
Closed
40 tasks
@emteknetnz emteknetnz marked this pull request as draft July 5, 2022 03:25
@emteknetnz emteknetnz force-pushed the pulls/4.10/module-standards branch from a44cde7 to a6b2d20 Compare July 5, 2022 04:15
@emteknetnz emteknetnz marked this pull request as ready for review July 14, 2022 21:38
GuySartorelli
GuySartorelli requested changes Jul 15, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're missing at least these two jobs from the travis config:

  • recipe-ccl unit tests
  • recipe-solr-search unit tests

The following deprecated modules are being tested, and they shouldn't:

  • cwp-recipe-cms
  • cwp-recipe-search
  • cwp-recipe-core

README.md Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/4.10/module-standards branch from a6b2d20 to 47a3757 Compare July 17, 2022 22:45
@emteknetnz
Copy link
Member Author

Have updated phpunit config file, correct jobs should get created now

GuySartorelli
GuySartorelli approved these changes Jul 17, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is super failing but I can't see anything wrong with the config so it can be treated with the other failures in silverstripe/gha-ci#37

@GuySartorelli GuySartorelli merged commit 396b296 into silverstripe:4.10 Jul 17, 2022
@GuySartorelli GuySartorelli deleted the pulls/4.10/module-standards branch July 17, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli